Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing react key on settings menu fragment #1757

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

dsmmcken
Copy link
Contributor

No description provided.

@dsmmcken dsmmcken requested a review from bmingles January 30, 2024 16:43
@dsmmcken dsmmcken self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f0ae055) 45.99% compared to head (477b6a3) 45.99%.

Files Patch % Lines
packages/code-studio/src/settings/SettingsMenu.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1757   +/-   ##
=======================================
  Coverage   45.99%   45.99%           
=======================================
  Files         626      626           
  Lines       37576    37576           
  Branches     9450     9450           
=======================================
  Hits        17284    17284           
  Misses      20237    20237           
  Partials       55       55           
Flag Coverage Δ
unit 45.99% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsmmcken dsmmcken merged commit b14b714 into main Jan 30, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_fix_missing_key_settingsa branch January 30, 2024 23:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants